-
Couldn't load subscription status.
- Fork 146
Fix broken docs-build by pinning protobuf-3.20.x #1033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D72016216 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
3f32f8c to
805e953
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72016216 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D72016216 |
Summary: Pull Request resolved: #1033 `apache-airflow>2.6.3` (installed in `docs/requirements.txt`) transitively brings in `opentelemetry` which depends on `protobuf>=4.x`. This version of `protobuf` conflicts with the one required by `kfp==1.8.x` (`protobuf <= 3.20.x`). What we oughta do is to upgrade to `kfp-2.x` but that's a much more intrusive change as we are bumping major versions. So pin to `apache-airflow==2.6.3` so that protobuf doesn't conflict with kfp. Reviewed By: tonykao8080 Differential Revision: D72016216
805e953 to
6f39c6e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72016216 |
Summary: Pull Request resolved: #1033 Pin protobuf-3.20.x (required by kfp-1.8.22) in dev-requirements and first install docs/requirements.txt then downgrade protobuf to 3.20.x. What we oughta do is to upgrade to `kfp-2.x` but that's a much more intrusive change as we are bumping major versions. So pin to `apache-airflow==2.6.3` so that protobuf doesn't conflict with kfp. Reviewed By: tonykao8080 Differential Revision: D72016216
6f39c6e to
d824757
Compare
Summary: Pull Request resolved: #1033 Pin protobuf-3.20.x (required by kfp-1.8.22) in dev-requirements and first install docs/requirements.txt then downgrade protobuf to 3.20.x. What we oughta do is to upgrade to `kfp-2.x` but that's a much more intrusive change as we are bumping major versions. So pin to `apache-airflow==2.6.3` so that protobuf doesn't conflict with kfp. Reviewed By: tonykao8080 Differential Revision: D72016216
|
This pull request was exported from Phabricator. Differential Revision: D72016216 |
d824757 to
5b979cf
Compare
Summary: Pin protobuf-3.20.x (required by kfp-1.8.22) in dev-requirements and first install docs/requirements.txt then downgrade protobuf to 3.20.x. What we oughta do is to upgrade to `kfp-2.x` but that's a much more intrusive change as we are bumping major versions. So pin to `apache-airflow==2.6.3` so that protobuf doesn't conflict with kfp. Reviewed By: tonykao8080 Differential Revision: D72016216
5b979cf to
9ffd30f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72016216 |
Summary: Pin protobuf-3.20.x (required by kfp-1.8.22) in dev-requirements and first install docs/requirements.txt then downgrade protobuf to 3.20.x. What we oughta do is to upgrade to `kfp-2.x` but that's a much more intrusive change as we are bumping major versions. So pin to `apache-airflow==2.6.3` so that protobuf doesn't conflict with kfp. Reviewed By: tonykao8080 Differential Revision: D72016216
9ffd30f to
eda24ed
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72016216 |
Summary: Pin protobuf-3.20.x (required by kfp-1.8.22) in dev-requirements and first install docs/requirements.txt then downgrade protobuf to 3.20.x. What we oughta do is to upgrade to `kfp-2.x` but that's a much more intrusive change as we are bumping major versions. So pin to `apache-airflow==2.6.3` so that protobuf doesn't conflict with kfp. Reviewed By: tonykao8080 Differential Revision: D72016216
eda24ed to
9753fa7
Compare
Summary: Pull Request resolved: #1033 Pin protobuf-3.20.x (required by kfp-1.8.22) in dev-requirements and first install docs/requirements.txt then downgrade protobuf to 3.20.x. What we oughta do is to upgrade to `kfp-2.x` but that's a much more intrusive change as we are bumping major versions. So pin to `apache-airflow==2.6.3` so that protobuf doesn't conflict with kfp. Reviewed By: tonykao8080 Differential Revision: D72016216
|
This pull request was exported from Phabricator. Differential Revision: D72016216 |
9753fa7 to
3479f02
Compare
Summary: I fixed doc-build in #1033 by: 1. pinning `protobuf-3.20.x` in torchx's `dev-requirements.txt` since `apache-airflow` (defined in `docs/requirements.txt`) was upgrading to `protobuf>=5.x` which is incompatible with `kfp-1.8.x`. 2. installing `doc/requirements.txt` FIRST, then installing `torchx` so that the pinned version of `protobuf` is honored. The above fixes `doc-build` but not `doc-push` because `doc-push` runs `scripts/doc-push.sh` which needed the same change as #2. Differential Revision: D72059926
Summary: I fixed doc-build in #1033 by: 1. pinning `protobuf-3.20.x` in torchx's `dev-requirements.txt` since `apache-airflow` (defined in `docs/requirements.txt`) was upgrading to `protobuf>=5.x` which is incompatible with `kfp-1.8.x`. 2. installing `doc/requirements.txt` FIRST, then installing `torchx` so that the pinned version of `protobuf` is honored. The above fixes `doc-build` but not `doc-push` because `doc-push` runs `scripts/doc-push.sh` which needed the same change as #2. NOTE: this wasn't caught in #1033 because we don't run `doc-push` for PRs (doc-push only runs for releases and commits in trunk since it literally pushes the built docs to https://pytorch.org/torchx) Differential Revision: D72059926
Summary: Pull Request resolved: #1034 I fixed doc-build in #1033 by: 1. pinning `protobuf-3.20.x` in torchx's `dev-requirements.txt` since `apache-airflow` (defined in `docs/requirements.txt`) was upgrading to `protobuf>=5.x` which is incompatible with `kfp-1.8.x`. 2. installing `doc/requirements.txt` FIRST, then installing `torchx` so that the pinned version of `protobuf` is honored. The above fixes `doc-build` but not `doc-push` because `doc-push` runs `scripts/doc-push.sh` which needed the same change as #2. NOTE: this wasn't caught in #1033 because we don't run `doc-push` for PRs (doc-push only runs for releases and commits in trunk since it literally pushes the built docs to https://pytorch.org/torchx) Differential Revision: D72059926
Summary: Pull Request resolved: #1034 I fixed doc-build in #1033 by: 1. pinning `protobuf-3.20.x` in torchx's `dev-requirements.txt` since `apache-airflow` (defined in `docs/requirements.txt`) was upgrading to `protobuf>=5.x` which is incompatible with `kfp-1.8.x`. 2. installing `doc/requirements.txt` FIRST, then installing `torchx` so that the pinned version of `protobuf` is honored. The above fixes `doc-build` but not `doc-push` because `doc-push` runs `scripts/doc-push.sh` which needed the same change as #2. NOTE: this wasn't caught in #1033 because we don't run `doc-push` for PRs (doc-push only runs for releases and commits in trunk since it literally pushes the built docs to https://pytorch.org/torchx) Differential Revision: D72059926
Differential Revision: D72016216